[PATCH 2 of 2] parsers: add a C function to pack the dirstate

[Bryan O'Sullivan]

On Thu, May 17, 2012 at 7:08 AM, Antoine Pitrou <solipsis at pitrou.net> wrote:

> Py_INCREF shouldn't be needed here (PyDict_SetItem doesn't steal a
> reference).
>

Good catch, thanks.


> > +     if (dirstate_unset)
> > +             PyObject_GC_UnTrack(dirstate_unset);
>
> Any reason for the PyObject_GC_UnTrack call?
>

Keeping a long-lived object out of the GC's root set.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120522/3b8aebda/attachment.html>