[PATCH 2 of 6] graphlog: turn getlogrevs() into a generator

Matt Mackall mpm at selenic.com
Wed May 23 14:44:19 CDT 2012


On Wed, 2012-05-23 at 09:44 +0200, Patrick Mézard wrote:
> Le 22/05/12 21:37, Matt Mackall a écrit :
> > On Tue, 2012-05-08 at 22:58 +0200, Patrick Mezard wrote:
> >> # HG changeset patch
> >> # User Patrick Mezard <patrick at mezard.eu>
> >> # Date 1336509824 -7200
> >> # Node ID 53db775e252c0f4f7add32b62e08096814d3ab7e
> >> # Parent  d30440da7b38c671266ae1734db3921475a63caa
> >> graphlog: turn getlogrevs() into a generator
> > 
> > Queued these first two for default, thanks. Still mulling the rest, I'm
> > afraid.
> 
> By the way, I am not really attached to the precompute thing. This is
> just the simplest/less invasive trick I found to "solve" the issue at
> hand. The fundamental issues are:
> - There is no execution context provided to revset functions, which makes caching and rewriting harder to implement.
> - Being made of tuples, it is pretty hard to annotate the AST.

Yeah, I think we'll need to do something here. But I think I'd rather
start down the path of implementing an incremental revset framework and
see where that gets us. It will almost certainly need a caching scheme
but it probably won't look much like this one.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list