[PATCH 1 of 1] acl: skip unneeded lines in hg output

Elifarley Callado Coelho Cruz elifarley at gmail.com
Wed May 30 11:45:15 CDT 2012


Cameron wrote:

On a purely stylistic note, I prefer to write this kind of thing thus:
> sed -e '
> /^files:/d
> /^bundling:/d
> /^changesets:/d
> /^manifests:/d
> /^searching for changes/d
> /^all remote heads known locally/d
> /^invalidating branch cache/d
> '
> because it far easier to read/debug/modify.


Cameron,


I was not aware that you could pass multiple expressions to sed as you
suggested.

It does look better and easier to work with, so I'll send another patch
with your suggestion. Thanks!

Regarding the "2>&1": it was intentional:
1) I must filter out some lines that go to stderr, like "invalidating
branch cache (tip differs)", so if I get a single stream of lines, it's
easy to filter some of them, regardless of their origin
2) I was not really interested in the exit status of the command. If the
exit status changes, then the previous lines will most likely change too

Despite 2), I'll post a patch which prints a different line according to
the exit status of the hg push command.

Thanks you,

Elifarley Cruz

Google Plus: http://bit.ly/elifarley-plusposts
Google Reader: http://bit.ly/elifarley-reader
Bookmarks: http://delicious.com/elifarley
Professional info: http://linkd.in/elifarley  |
http://openhatch.org/people/elifarley/
http://twitter.com/elifarley
-

 " Do not believe anything because it is said by an authority, or if it  is
said to come from angels, or from Gods, or from an inspired source.
Believe it only if you have explored it in your own heart and mind and body
and found it to be true.  Work out your own path, through diligence."
- Gautama Buddha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120530/a03143df/attachment.html>


More information about the Mercurial-devel mailing list