[Bug 3475] New: Adding msvcrt module to demandimport ignore list

bugzilla-daemon at bz.selenic.com bugzilla-daemon at bz.selenic.com
Wed May 30 22:20:05 CDT 2012


http://bz.selenic.com/show_bug.cgi?id=3475

          Priority: normal
            Bug ID: 3475
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: Adding msvcrt module to demandimport ignore list
          Severity: bug
    Classification: Unclassified
                OS: Other
          Reporter: yomgui1 at gmail.com
          Hardware: Other
            Status: UNCONFIRMED
           Version: 2.2.1
         Component: Mercurial
           Product: Mercurial

getpass module in python stdlib does getpass function assignement using a
sequence of try/except.

But demandimport (enabled by default in hg script) causes the second import on
msvcrt success, giving a "unloaded module", if the running platform doesn't
support termios and if platform is not windows also.

So getpass.getpass() is assigned to the windows getpass function, even if
platform is not Windows.

This cause the side effect to affect ui.getpass(), that will fail by attempt to
call win_getpass() on a non Windows platform.

Possible fix: adding 'msvcrt' to demandimport's ignore list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list