[PATCH] hgk: use Ttk instead of plain Tk

[Nikolaj Sjujskij]

Den 2012-11-07 23:13:05 skrev Matt Mackall <mpm at selenic.com>:

> On Wed, 2012-11-07 at 19:19 +0100, Andrew Shadura wrote:
>> Hello,
>>
>> On Wed, 07 Nov 2012 19:13:33 +0100
>> Mads Kiilerich <mads at kiilerich.com> wrote:
>>
>> > > Use Ttk for most of the widgets. Default to xpnative theme on
>> > > Windows, clam otherwise.
>>
>> > What is Ttk? Is it available on all Tk installations? Or how widely
>> > available is it? Did it ship with Python 2.4 which Mercurial still
>> > supports?
>>
>> Ttk is available on all Tk >=8.5 installations, and is available as an
>> add-on for Tk 8.4. As Tk 8.4 is EOLed already, and 8.5 is available
>> pretty everywhere (and 8.6 is about to be released), it doesn't make any
>> sense to not use it.
>
> You've given us no hint what a 'ttk' is yet or why we'd want it. I see
> it's 'themable widgets' - that's probably a good thing.
>
> But let me rephrase Mads' question more directly: what about users who
> are trying to run Mercurial on the most decrepit-but-still-widely-used
> RHEL releases? Will they have to update Tk too? This matters because
> they're the group most likely to be dependent on hgk.
>
> Unfortunately, it looks like this is a problem. Tk 8.5 was released in
> late 2007, but RHEL 5 was released in early 2007, so they're still on Tk
> 8.4. We have lots of RHEL 5 users; having their hgk stop working when
> they try to upgrade hg is not ok.
>
> (Yes, we're really this conservative about dependencies.)
>
> If you could arrange for hgk to use ttk only if available, this might be
> doable.
  I've just installed Tcl/Tk 8.4, pulled in Andrew's changes, merged and  
run `contrib/hgk`. It seemed to work fine, then I've upgraded Tcl/Tk to  
8.5 and now I can definitely see the improvements (without modifying the  
code).

(the first and probably last time I run hgk)