[PATCH 2 of 3] run-tests: remove resultslock since it serves no useful purpose

Siddharth Agarwal sid0 at fb.com
Fri Nov 9 19:59:22 CST 2012


On 11/09/2012 05:51 PM, Matt Mackall wrote:
> I'm afraid this will be backed out when I get back on Monday. This code
> was not a relic of dead code (the original code that Bryan wrote in 2007
> had no locking), it is new work in progress. My plan was to eliminate
> the whole mess of launching child copies of run-tests and marshaling
> results and instead use Python threading for scheduling tests (which,
> unlike just about everything else you might want to do with threads in
> Python, it should work just fine for).

Indeed -- I was wondering why threads weren't used in the first place.

> This work was about 90% done and, coincidentally, would have obviated
> the need to change the IPC scheme. My eventual goal is to be able to
> farm out tests to other machines based on load ala distcc, so I need a
> much tidier scheduler.

I see -- sorry. I made the change because I was trying to figure out 
whether the list of times would need a lock. (When you switch to 
threading, it would.)

> (Also, fyi, pickle is acceptable in run-tests but basically nowhere else
> in the codebase due to its hopeless insecurity. Similarly, marshal.)
>

That makes sense.

- Siddharth


More information about the Mercurial-devel mailing list