Request vetting a fix for my win32lfn extension
Mads Kiilerich
mads at kiilerich.com
Sat Nov 10 15:21:42 CST 2012
Aaron Cohen wrote, On 11/08/2012 12:11 AM:
> Since around Mercurial 2.3, my extension has been broken, by the
> change to move pack_dirstate to C.
>
> I don't do a very good job of updating and testing new versions, so
> recently a bug was filed against it which was the first time I know if
> it. I've now "fixed" it, but I would appreciate some help determining
> if my fix is correct.
>
> Basically, win32lfn replaces python's normal os.listdir with a call to
> FindFilesIterator.
You should keep an eye on what is going on with the development of the
vfs api in scmutil. That is in principle what you should be wrapping
instead of monkey patching os. It might not be ready yet, but that just
means that you still have a chance to influence it so it also is a nice
fit for your use case ;-)
/Mads
More information about the Mercurial-devel
mailing list