[PATCH] convert: add support for converting git submodule (issue3528)
Bryan O'Sullivan
bos at serpentine.com
Tue Nov 13 11:07:49 CST 2012
On Mon, Nov 12, 2012 at 3:20 PM, YaNan Xu <robot9 at fb.com> wrote:
> The converter will abort a convertion when encountering git submodules.
>
The patch mostly looks good, thanks.
There's one problem with the description: I don't understand the sentence I
quoted above, because it seems to contradict the purpose of the patch. Does
the above sentence describe the *old* behaviour of convert, or a
*new*behaviour, or a behaviour that
*remains the same*?
Below would be a clearer replacement for the above sentence, assuming I
understand what is happening.
"Previously, convert aborted upon encountering a git submodule. This patch
changes it so that it now succeeds, and ...*the rest of your description...*
"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121113/eef99db9/attachment.html>
More information about the Mercurial-devel
mailing list