[PATCH 2 of 2] hg: share supports bookmarks and uses same update targets as clone

Matt Mackall mpm at selenic.com
Wed Nov 14 19:34:58 CST 2012


On Tue, 2012-11-06 at 00:08 +0100, Simon Heimberg wrote:
> # HG changeset patch
> # User simon at laptop-tosh
> # Date 1351339146 -7200
> # Branch stable
> # Node ID c97840a340fb33b783b3dbbec7a6a04140de32ba
> # Parent  7425c0c92b2ee79e4e9271c3307d44290bc0977b
> hg: share supports bookmarks and uses same update targets as clone

This sort of commit message is confusing. I'm not sure whether I should
read it as

 share now supports bookmarks, thanks to this patch

or

 share already supports bookmarks, therefore...

It's helpful to have an explicit action (fix, add, change) so that such
confusion is avoided. In any case, the most appropriate 'topic' keyword
here is 'share', not 'hg'.

I think I'd like to see this as something like:

 clone: factor out update target selection
 share: use clone's target selection to add bookmark support 

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list