[PATCH 4 of 8 filtering] clfilter: decorate several repository methods as unfiltered

Matt Mackall mpm at selenic.com
Wed Nov 21 16:34:12 CST 2012


On Wed, 2012-11-21 at 15:44 +0100, Pierre-Yves David wrote:
> On Wed, Nov 21, 2012 at 10:11:39AM +0200, Idan Kamara wrote:
> > On Wed, Nov 21, 2012 at 2:11 AM, Pierre-Yves David
> > <pierre-yves.david at ens-lyon.org> wrote:
> > > # HG changeset patch
> > > # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> > > # Date 1353455266 -3600
> > > # Node ID 716cc4279f1ad69dde9a918508a11271e56b5212
> > > # Parent  4ae17fd97c2b3e0f9972c9cc093a3bc5e77c3f67
> > > clfilter: decorate several repository methods as unfiltered
> > 
> > The name of this decorator is a bit funny, how about renaming
> > the method 'unfiltered' to 'unfilter' and calling this decorator
> > 'unfiltered'?
> 
> Meh. I like the highlight that this decorator is intended for method.

Then at least name it 'method'. Precedent from Python: staticmethod,
classmethod. But all of Mercurial's own decorators don't do this.

Also: https://encrypted.google.com/search?q=meth

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list