[PATCH 1 of 5] diff: rewrite addmodehdr into addflagchangemeta

[Greg Ward]

On 21 November 2012, Guillermo Pérez said:
> # HG changeset patch
> # User Guillermo Pérez <bisho at fb.com>
> # Date 1352320114 28800
> # Node ID afc2d3d7a9aaac736efe291d5aff087743092467
> # Parent  a1f94e2f5da2dee4e107eab035685285d9923999
> diff: rewrite addmodehdr into addflagchangemeta
> 
> Mercurial handles flags rather than file modes, so it's better
> to signal flag changes and let the meta handler function
> adapt it to the needed header, file modes for git in particular
> but might be different if other patch methods are implemented.

I can't parse that sentence. I think the problem is that it's one
sentence. I honestly can't tell if it's grammatical English; if it is,
it's almost certainly ambiguous. Alternative:

  Mercurial tracks flags rather than file modes, so it's better to
  signal flag changes and let the meta handler function adapt it to
  the needed header. In particular, translate Mercurial flags to
  git-style modes in addflagchangemeta() rather than in the caller to
  addmodehdr(). This could be used to support other patch header
  syntaxes than git's.

...assuming that wording correctly describes your patch. ;-)

       Greg