[PATCH 2 of 3 V2] revlog: switch findmissing to use ancestor.missingancestors, and add a revs variant

Greg Ward greg at gerg.ca
Thu Nov 22 09:57:13 CST 2012


On 21 November 2012, Siddharth Agarwal said:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1353547305 28800
> # Node ID 09b23b668aac8fa8a45e60a0c6dd0f9563ca1700
> # Parent  562ed7c273988f91645be6189b51ab3119752c09
> revlog: switch findmissing to use ancestor.missingancestors, and add a revs variant

Sounds like two changes to me. See
http://mercurial.selenic.com/wiki/OneChangePerPatch . The fact that
you're adding an unused method smells bad.

In fact, I strongly suspect you want to add findmissingrevs() in your
next patch, where you actually use it.

       Greg


More information about the Mercurial-devel mailing list