[PATCH 1 of 3 V2] ancestor: a new algorithm for ancestors of a set of revs not in another set that is faster when the sets are close

Laurens Holst laurens.nospam at grauw.nl
Thu Nov 22 10:59:34 CST 2012


Op 22-11-12 16:56, Greg Ward schreef:
> On 21 November 2012, Siddharth Agarwal said:
>> # HG changeset patch
>> # User Siddharth Agarwal <sid0 at fb.com>
>> # Date 1353546962 28800
>> # Node ID 562ed7c273988f91645be6189b51ab3119752c09
>> # Parent  536f5df951bece49b760392fd543e8082489b7d0
>> ancestor: a new algorithm for ancestors of a set of revs not in another set that is faster when the sets are close
> To my surprise, http://mercurial.selenic.com/wiki/ContributingChanges
> says nothing about how long the first line of a commit message should
> be. But I'm pretty sure 80 chars is the absolute maximum beyond which
> thou shalt not go, and 75 chars is much better.

Quote: 
http://mercurial.selenic.com/wiki/ContributingChanges#Patch_descriptions

> all lines less than 80 characters

The 65 character limit described on the page Adrian linked is imo too 
restrictive, by imposing such a limit you reduce the expressiveness and 
thus the value of the summary. Git has a similarly restrictive 
convention (even 50 chars max I think) which makes the summary line 
pretty much useless.

~Laurens



More information about the Mercurial-devel mailing list