[PATCH] phases: fix missing import (issue 3707)

Nikolaj Sjujskij sterkrig at myopera.com
Fri Nov 23 15:57:18 CST 2012


Den 2012-11-24 01:49:27 skrev Greg Ward <greg at gerg.ca>:

> On 24 November 2012, Nikolaj Sjujskij said:
>> Den 2012-11-23 01:22:30 skrev André Sintzoff <andre.sintzoff at gmail.com>:
>>
>> ># HG changeset patch
>> ># User André Sintzoff <andre.sintzoff at gmail.com>
>> ># Date 1353619323 -3600
>> ># Branch stable
>> ># Node ID d8fe17b1b2d117ff903e14d3d89aa1bc51a739ab
>> ># Parent  54cedee86e5126188b0dcfbd7015bcdca7f6c2e2
>> >phases: fix missing import (issue 3707)
>>
>> 1. I think it's worth to mention *what* module wasn't imported
> Disagree -- that's obvious from the patch.
Sure, but it's not so obvious when you look at `hg log` output (without  
--patch) or hgweb log. And it's only one additional word. I think that  
there's no such thing as a "too obvious commit message", provided it's  
short and clear.

Anyway, it's no big deal in this case


More information about the Mercurial-devel mailing list