[PATCH] hgweb: display difference for a changeset against any parents (issue2810)

Weiwen Liu weiwen at fb.com
Mon Nov 26 17:10:07 CST 2012


Yes, the iterator is exhausted after we use it once.  We used parent
iterator earlier on "<td class="author">{parent%changesetparent}</td>".

Let me see if I can find a way to reset the iterator.


On 11/26/12 2:59 PM, "Matt Mackall" <mpm at selenic.com> wrote:

>[cc:ed back to the list]
>
>On Mon, 2012-11-26 at 22:40 +0000, Weiwen Liu wrote:
>> Hi Matt,
>> 
>> I just got back from nice Thanksgiving break.  Hope you had a great
>> Thanksgiving break too.
>> 
>> Now coming back to this change, I'd like to display web page as
>> 
>> 	Change baseline: http://.../rev/y:p1(y)  http://.../rev/y:p2(y)
>> 	Current baseline: http://.../rev/x
>> 
>> We will need to pass one datum x in order to display "Current baseline"
>> 
>> In order to display available baselines to diff against, I pass the
>> original node, y, and an iterator to report all parents of y (I can't
>> reuse the current iterator parent).
>
>This is probably the confusion. Why not?
>
>If it's because it's an iterator, and is thus exhausted after we use it
>once, then that seems like a bug we should fix.
>
>-- 
>Mathematics is the supreme nostalgia of our time.
>
>



More information about the Mercurial-devel mailing list