[PATCH] hgweb: display difference for a changeset against any parents (issue2810)

Weiwen Liu weiwen at fb.com
Thu Nov 29 12:08:15 CST 2012


Yes.
________________________________________
From: Kevin Bullock [kbullock+mercurial at ringworld.org]
Sent: Thursday, November 29, 2012 10:02 AM
To: Weiwen Liu
Cc: mercurial-devel at selenic.com; Matt Mackall; Bryan O'Sullivan
Subject: Re: [PATCH] hgweb: display difference for a changeset against any parents (issue2810)

On Nov 29, 2012, at 12:00 PM, Weiwen Liu wrote:

> I looked at the result after removing spaces.
>
> Removing space from
>> + <td class="author"><a href="{url}rev/{currentbaseline|short}{sessionvars%urlparameter}">{currentbaseline|short}</a> </td>
> works fine.
>
> After removing space from
>> +changesetbaseline = '<a href="{url}rev/{node|short}:{originalnode|short}{sessionvars%urlparameter}">{node|short} </a> '
> we display two parents without space in between.  We need to keep the space here.  The changesetparent has a space at the end for the same reason.  I will keep this space.

Makes sense, but let's at least eliminate the extra space *before* the </a>.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list