[PATCH 4 of 4] dirstate: avoid use of zip on big lists

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Nov 30 17:02:30 CST 2012


On Nov 30, 2012, at 4:20 PM, Bryan O'Sullivan wrote:

> # HG changeset patch
> # User Bryan O'Sullivan <bryano at fb.com>
> # Date 1354313955 28800
> # Node ID ab0ec24445a5402cfc3322ac515c1ab3368b833c
> # Parent  59ca9fefdb7d956cb76d04f3acc420289736957e
> dirstate: avoid use of zip on big lists
> 
> In a clean working directory containing 170,000 tracked files, this
> improves performance of "hg --time diff" from 1.69 seconds to 1.43.

Seems like this should've been first in the series, but 1, 2, and 4 LGTM. I'm not in a position to comment on 3. I can read C, but I know nothing about PyC.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list