[PATCH 4 of 4] dirstate: avoid use of zip on big lists

Matt Mackall mpm at selenic.com
Fri Nov 30 18:35:05 CST 2012


On Fri, 2012-11-30 at 16:20 -0800, Bryan O'Sullivan wrote:
> On Fri, Nov 30, 2012 at 4:07 PM, Matt Mackall <mpm at selenic.com> wrote:
>         
>         
>         Further, if we're motivated by space overhead, the list passed
>         to
>         statfiles could be a generator. That tends to be a loss on
>         non-gigantic
>         lists though.
> 
> 
> I tried a few variants on the statfiles approach earlier in the day,
> and this turned out to perform the best. Passing in a generator was
> slower, for instance.
>  
>         As this is apparently the only user of statfiles, perhaps a
>         better API
>         is possible.
> 
> 
> The only maybe-better approach I could think of was to pass the dict
> to be modified to statfiles and let it modify it directly, but that's
> just yucky as an API. 

Still want perfstatus.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list