[PATCH 1 of 4] dirstate: move file type filtering to its source

Matt Mackall mpm at selenic.com
Fri Nov 30 18:59:57 CST 2012


On Fri, 2012-11-30 at 14:20 -0800, Bryan O'Sullivan wrote:
> # HG changeset patch
> # User Bryan O'Sullivan <bryano at fb.com>
> # Date 1354313740 28800
> # Node ID 874a5aac379f0798c758797f24abf1f7be9f05d7
> # Parent  2f04000f7c355f505b788880ee7987ca63643cf2
> dirstate: move file type filtering to its source
> 
> This prepares us to move to a much faster statfiles implementation on Unix.

This introduces a layering violation: here at the lowest level of the
stack, we shouldn't have hardcoded knowledge about what kinds of files
statfiles callers might be interested in. I'd suggest passing in a type
mask, but the stat file-type bits aren't bitwise-orthogonal.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list