[PATCH 1 of 4] dirstate: move file type filtering to its source

Bryan O'Sullivan bos at serpentine.com
Sat Dec 1 01:13:06 UTC 2012


On Fri, Nov 30, 2012 at 4:59 PM, Matt Mackall <mpm at selenic.com> wrote:

> This introduces a layering violation: here at the lowest level of the
> stack, we shouldn't have hardcoded knowledge about what kinds of files
> statfiles callers might be interested in.
>

That's a good point. On the other hand, dirstate is the only user of the
code. Maybe this is more of a namespace issue than a layering problem - we
have a specialised function with one user, and no obviously better place to
put it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121130/7691a1a7/attachment.html>


More information about the Mercurial-devel mailing list