[PATCH 2 of 5] histedit: replace various nodes lists with replacement graph (and issue3582)

Augie Fackler raf at durin42.com
Thu Oct 4 17:19:37 CDT 2012


On Oct 3, 2012, at 12:15 PM, Dave S <snidely.too at gmail.com> wrote:

> On Wed, Oct 3, 2012 at 10:11 AM, Dave S <snidely.too at gmail.com> wrote:
>>> Changeset dropping are recorded as "old" is
>>> replaced by [].
>> 
>> I'm not sure how to interpret this.  Maybe 'Changesets recorded as
>> "old" are replaced by "[]" '....' ???
>> (Or, looking again, 'The list of changesets recorded as "old" are
>> replaced by an empty list' ???)
> 
> Sent before spotting this:
> 
> "The old `created`, `replaced` and `tmpnodes` are not longer returned and they
> not longer exists throughout the histedit operation."
> 
> which may be more readable as "The old `created`, `replaced`, and
> `tmpnodes` are _no_ longer returned, and they _no_ longer _exist_ in
> the histedit operation."
> [Forgive the usenettish highlighting; also, you can see I omitted
> _throughout_ as I am not sure it adds anything, but if I'm wrong then
> I'd try _anywhere in_.]

Sounds good to me.

> 
> /dps
> -- 
> test signature -- please apply at front gate on Tuesdays only.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list