[PATCH] localrepo: drop useless `_writebookmarks`

[Kevin Bullock]

On 5 Oct 2012, at 10:16 AM, Augie Fackler wrote:

> Please no. I actually need to finish cleaning this up, but it makes
> implementing bookmarks support MUCH more difficult for non-localrepo
> subclasses if the locking etc happens in a helper method like
> bookmarks.write.
> 
> I actually /need/ this to go the other way: have the locking handled
> by the repo class, and then only call out to bookmarks.py for the
> bookmark-specific logic.

It seems a little strange that MQ is handling writing the bookmarks at all. I would think the most we'd want extensions to be able to do is provide a new target rev for bookmarks, but let the repo actually handle updating them.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121005/0da794e2/attachment.html>