[PATCH hglib] client: add purge command

Martin Geisler martin at geisler.net
Sun Oct 7 14:43:16 CDT 2012


Idan Kamara <idankk86 at gmail.com> writes:

> On Tue, Oct 2, 2012 at 10:46 PM, Matt Mackall <mpm at selenic.com> wrote:
>>
>> On Tue, 2012-10-02 at 22:12 +0200, Idan Kamara wrote:
>> > On Tue, Oct 2, 2012 at 8:24 PM, Victor Garcia <bravejolie at gmail.com>
>> > wrote:
>> > >
>> > > # HG changeset patch
>> > > # User victor
>> > > # Date 1349202168 -7200
>> > > # Node ID 6172601e7f7b3d7c8c3539e2758cfba8ab0784a4
>> > > # Parent  e5d3b0aa48e6ab79531204f61e25ee335b306df3
>> > > client: add purge command
>> >
>> > Thanks for sending this here.
>> >
>> > >
>> > > Adding the purge command to hglib. Since it's an extension, appending
>> > > '--config extensions.hgext.purge=' to enable it
>> >
>> > Like I said earlier once an extension is enabled, it lingers in
>> > the cmdserver
>> > process forever (since they're managed in a global variable). I guess
>> > that's
>> > harmless here.
>>
>> Not sure if I'm excited about supporting random convenience extensions
>> in hglib.
>
> I think it's useful to support extensions in general, but I agree
> that adding it to the client class directly might not be the best
> option.
>
> Martin, how does JavaHg handle extensions?

The program has to declare the extensions it want to use when starting
the command server. So the extensions are loaded once at that point and
will then stay around in the command server.

-- 
Martin Geisler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121007/64f139a9/attachment.pgp>


More information about the Mercurial-devel mailing list