[PATCH STABLE] largefiles: distinguish
FUJIWARA Katsunori
foozy at lares.dti.ne.jp
Mon Oct 8 09:10:33 CDT 2012
At Sun, 7 Oct 2012 21:59:11 +0000 (UTC),
Matt Harbison wrote:
>
> FUJIWARA Katsunori <foozy <at> lares.dti.ne.jp> writes:
>
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy <at> lares.dti.ne.jp>
> > # Date 1349453429 -32400
> > largefiles: distinguish "no remote repo" from "no file to upload" (issue3651)
>
> [..]
>
> > @@ -997,6 +997,8 @@
> > + elif not toupload:
> > + ui.status(_('largefiles: no file to upload\n'))
> > else:
> > ui.status(_('largefiles to upload:\n'))
>
> > @@ -1016,6 +1018,8 @@
> > + elif not toupload:
> > + ui.status(_('largefiles: (no file to upload)\n'))
> > else:
> > ui.status(_('largefiles: %d to upload\n') % len(toupload))
>
> Trivial nit: I think most places in the code use 'files' instead of 'file' for
> output. That would read better in this case. Otherwise, LGTM.
Thank you for your comment, Matt.
I'll repost one refined so.
----------------------------------------------------------------------
[FUJIWARA Katsunori] foozy at lares.dti.ne.jp
More information about the Mercurial-devel
mailing list