[PATCH 1 of 6 A2 series] pathencode: add _lowerencode function

Adrian Buehlmann adrian at cadifra.com
Mon Oct 8 18:07:21 CDT 2012


On 2012-10-08 19:35, Adrian Buehlmann wrote:
> Sure.
> 
> On 2012-10-08 19:17, Bryan O'Sullivan wrote:
>> On Sat, Oct 6, 2012 at 4:52 AM, Adrian Buehlmann <adrian at cadifra.com
>> <mailto:adrian at cadifra.com>> wrote:
>>
>>     This code was originally published by Bryan O'Sullivan
>>     <bryano at fb.com <mailto:bryano at fb.com>>
>>     on 2012-09-10 <tel:2012-09-10> as part of a bigger patch, which
>>     wasn't included.
>>
>>
>> Please don't change the attribution on patches you didn't originate. I
>> don't want to have to explain to Facebook's legal team why your name is
>> on a commit even though Facebook owns the rights to the code.
>>
>> If you'd like me to extract a hunk of a patch and resubmit it by itself,
>> just ask.

Some further notes on the legalese involved here.

Your dislike has been well noted here.

But:

If you send a patch to this list, you publish it. You've thus created a
derived work, which was published under the GPL too. I am thus free to
take and bend your patch in whatever ways I please.

I don't have to wait with my modifications until your patch hits the
main Mercurial repo. Because your patch may not even reach the main repo
ever.

I "own" the code as much as you or Facebook do.

If I see a patch that someone has published here and I would like to
make a derived work of that patch, I think I am free to do so.

I even openly noted in the change message from where I got the work I
based my work on.

My "work" consist in splitting up your patch and putting it in new context.

FWIW, I didn't even mean to have my patches in this series included.
As I wrote in the introductory message:

On 2012-10-06 11:52, Adrian Buehlmann wrote:
> Not really meant to be pushed. Just for consideration.

Also, I changed the committer to *my* name, as I didn't want to have you
blamed for errors that were caused by me (by having splitted your patch
and put it into a different series).


More information about the Mercurial-devel mailing list