3c775c5a6c03 breaks test-dirstate.t

Adrian Buehlmann adrian at cadifra.com
Tue Oct 9 05:33:12 CDT 2012


On 2012-10-09 11:44, Thomas Arendsen Hein wrote:
> * Thomas Arendsen Hein <thomas at intevation.de> [20121009 10:13]:
>> * Mercurial Commits <hg at intevation.org> [20121009 00:55]:
>>> http://selenic.com/repo/hg//rev/3c775c5a6c03
>>> changeset:   17733:3c775c5a6c03
>>> tag:         tip
>>> user:        Matt Mackall <mpm at selenic.com>
>>> date:        Mon Oct 08 17:50:42 2012 -0500
>>> summary:     dirstate: handle large dates and times with masking (issue2608)
>>
>> --- /home/thomas/hg/repos/tah/tests/test-dirstate.t
>> +++ /home/thomas/hg/repos/tah/tests/test-dirstate.t.err
>> @@ -56,9 +56,11 @@
>>  Test modulo storage/comparison of absurd dates:
>>    
>>    $ touch -t 250001011200 a
>> +  touch: invalid date format `250001011200'
>> +  [1]
>>    $ hg st
>>    $ hg debugstate
>> -  n 644          2 2023-08-24 13:21:04 a
>> +  n 644          2 2021-01-01 12:00:00 a
>>    $ touch -t 195001011200 a
>>    $ hg st
>>    $ hg debugstate
>>
>> (Debian squeeze 32bit on NFS drive)

FWIW, that test fails in the same way on Windows 7 x64 with x64 Python
2.7.3 (and x64 hg.exe) in MSYS.

> As I assumed this is caused by the 32bit system.
> 
> NFS using the same server (32bit, too) with a 64bit client works
> fine. A date past 2038 will show as being in the past on 32bit
> clients.
> 
> I suggest simply removing the test with 250001011200, tests with
> a negative date should already show enough. The more complicated
> alternative would be to introduce a 64bit check in hghave.


More information about the Mercurial-devel mailing list