[PATCH 3 of 9 V2] obsolete: clarify the obsstore `precursors` and `successors` mapping

Augie Fackler raf at durin42.com
Mon Oct 15 09:01:20 CDT 2012


On Oct 15, 2012, at 7:46 AM, pierre-yves.david at logilab.fr wrote:

> +    - precursors: old -> set(marker using <old> as precursor)
> +    - successors: new -> set(marker using <new> in successors)

This documentation helps a lot, thanks.

Given that this is internal code, I'd like to propose flipping the naming of these attributes. The reason being is that (probably because of my math background) I read obsolete.precursors(ctx) as "precursors of ctx", which sounds to me like the result of successors(ctx) in the current code. Does anyone else read the code that way?


More information about the Mercurial-devel mailing list