[PATCH] run-tests: paths do automatically match on Windows
simohe at besonet.ch
Mon Oct 15 16:39:34 CDT 2012
Am Montag, den 15.10.2012, 02:50 +0200 schrieb Mads Kiilerich:
> [CC back to list]
Why do I often plan but forget this?
> Simon Heimberg wrote, On 10/12/2012 06:19 PM:
> > Am Donnerstag, den 11.10.2012, 13:41 +0200 schrieb Mads Kiilerich:
> >> The advantage of the current '(glob)' approach is that it requires
> >> explicit markup ... and that is also the main disadvantage.
> >> The real problem here is IMO that ui.slash doesn't control all the
> >> places where we display native paths ... and there is no clean simple
> >> way to achieve that. We just want to handle that in the test suite for now.
> > ??? I do not understand what you mean, sorry.
> > * Should "/" always be used in output? This would confuse many users.
> As it is now it is very inconsistent whether we use / or \ in output.
> In principle we should use / for 'Mercurial' paths and \ for 'windows'
> paths. Even that is confusing.
> I think it would be more consistent and less confusing if we always
> showed / also on windows.
> That is however not going to happen any time soon ... if ever.
> > * Or should we set ui.slash to "/" when running tests on windows? (And
> > fix what is not converted.)
> We already do that.
> ui.slash is however almost useless.
> >> Most of the tests do now have the necessary markup and the maintenance
> >> overhead of the current approach is relatively low.
> >> http://www.selenic.com/pipermail/mercurial-devel/2012-October/045166.html is
> >> as an exception. (That kind of need for markup could however also be
> >> caught by a check-code warning.)
> > There are still many tests not marked. some examples: test-walk.t,
> > test-tag.t, test-subrepo.t, test-revert.t
> > (find more by running this in the tests directory:
> > grep "[a-Z]/[a-Z]" *.t | grep -v "(glob)" | grep -v " [>$]" | grep -v
> > 'ssh://\|http://' | grep -v ' ---\| +++'
> > )
> No; as far as I know these tests run just fine on windows.
> Mercurial do intentionally and correctly output / in a lot of places -
> also on windows.
> This discussion indicates either that I haven't understood what you are
> trying to achieve, or that you misunderstood how Mercurial and the tests
> works on Windows.
> Exactly what problem is it you are trying to solve?
Convinced, I did not understand how the tests work on windows. I have
understood that ALL paths should contain a (glob) at the end.
So forget my patches 3, 4 and 5 of the last sent series.
In feature, I will test the command on my windows machine with
ui.slash="/". And then I only append " (glob)" when a backslash is
More information about the Mercurial-devel