[PATCH 2 of 2] locate: honor ui.slash (issue1621)

Mads Kiilerich mads at kiilerich.com
Mon Oct 15 20:10:42 CDT 2012

Matt Mackall wrote, On 10/12/2012 10:05 PM:
> On Mon, 2012-08-20 at 21:51 +0200, Patrick Mezard wrote:
>> # HG changeset patch
>> # User Patrick Mezard <patrick at mezard.eu>
>> # Date 1345491285 -7200
>> # Node ID 15d9d61f6957390a0afcc4761cd657b2f174ab26
>> # Parent  461b362c4778512578087e422ce3cdb4bc5ea3f7
>> locate: honor ui.slash (issue1621)
> What's the status here?

In my opinion:

There is no way we ever can make ui.slash work as documented. The only 
way to fix that functionality vs documentation bug is thus to redefine 
the goal.

These patches are thus not necessarily a step in the right direction.

As mentioned/hinted elsewhere: I think it would be better to switch to 
always use / as slash internally. The vfs introduction could be used as 
an opportunity to introduce that and get rid of "all" uses of os.path.

That would probably give some optimizations, and it would also 
effectively change the default of ui.slash from false to true. Explicit 
handling of ui.slash=false conversion could perhaps be added the most 
important places - which probably is the places where we today have 
handling of ui.slash=true ... but it would probably be a better solution 
to drop ui.slash completely.


More information about the Mercurial-devel mailing list