[PATCH STABLE] win32mbcs: add reversing wrapper for some unicode-incompatible functions

Kevin Bullock kbullock+mercurial at ringworld.org
Wed Oct 17 11:40:46 CDT 2012


On Oct 17, 2012, at 11:39 AM, Kevin Bullock wrote:

> On Oct 17, 2012, at 4:34 AM, Shun-ichi Goto wrote:
> 
>> # HG changeset patch
>> # User Shun-ichi GOTO <shunichi.goto at gmail.com>
>> # Date 1350464940 -32400
>> # Node ID 59e2412b40596d398cecfc29d3a1b7f507b4fff2
>> # Parent  72c234081ae1350220132c69750f5a093902a1e7
>> win32mbcs: add reversing wrapper for some unicode-incompatible functions.
>> 
>> This changeset fix the problem to use win32mbcs with mercurial 2.3 or
>> later.  And also includes small changes for PEP8 and check-code.py
>> adaptation.
> 
> Is that why there's a bunch of unrelated whitespace changes in the patch? Those should be separate.
> 
> Otherwise the patch looks superficially fine to me.


Whoops, responded before I saw your other reply (and I'd forgotten about Matt's prior remarks). Sorry for the noise.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121017/f84dd279/attachment.html>


More information about the Mercurial-devel mailing list