[PATCH] convert: normalize paths in filemaps (issue3612)

Augie Fackler raf at durin42.com
Wed Oct 17 19:51:26 CDT 2012


I'd interpret mpm's message as indicating he did the cleanup.
On Oct 17, 2012 7:05 PM, "Huayang Guo" <huayang at fb.com> wrote:

> Hi, Matt,
>
> Thanks for your review. Just wondering if I should submit another diff to
> revise the issues given by contrib/check-node.py?
>
> Thanks,
>
> Huayang
>
> On 10/17/12 4:10 PM, "Matt Mackall" <mpm at selenic.com> wrote:
>
> >On Wed, 2012-10-17 at 14:01 -0700, Huayang Guo wrote:
> >> # HG changeset patch
> >> # User Huayang <huayang at fb.com>
> >> # Date 1349479654 25200
> >> # Node ID be43ef5cd839673f76dd0b65a9f053a6e3ac76af
> >> # Parent  fa714f3ed2989aff64c267c9935251d9fc4f31ee
> >> convert: normalize paths in filemaps (issue3612)
> >
> >Queued for default with some fixes. contrib/check-code.py has asked me
> >to tell you:
> >
> >hgext/convert/filemap.py:21:
> > >     ''' We use posixpath.normpath to support cross-platform path
> >format.
> > trailing whitespace
> >hgext/convert/filemap.py:23:
> > >     if path == None:
> > comparison with singleton, use 'is' or 'is not' instead
> >
> >--
> >Mathematics is the supreme nostalgia of our time.
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121017/8a19a661/attachment-0001.html>


More information about the Mercurial-devel mailing list