[PATCH] convert: normalize paths in filemaps (issue3612)

Huayang Guo huayang at fb.com
Wed Oct 17 19:56:40 CDT 2012

Oh, many thanks to your guys!


From: Augie Fackler <raf at durin42.com<mailto:raf at durin42.com>>
Date: Wed, 17 Oct 2012 19:51:26 -0500
To: Huayang Guo <huayang at fb.com<mailto:huayang at fb.com>>
Cc: Mads Kiilerich <mads at kiilerich.com<mailto:mads at kiilerich.com>>, Mercurial-devel <mercurial-devel at selenic.com<mailto:mercurial-devel at selenic.com>>, Bryan O'Sullivan <bryano at fb.com<mailto:bryano at fb.com>>, Matt Mackall <mpm at selenic.com<mailto:mpm at selenic.com>>
Subject: Re: [PATCH] convert: normalize paths in filemaps (issue3612)

I'd interpret mpm's message as indicating he did the cleanup.

On Oct 17, 2012 7:05 PM, "Huayang Guo" <huayang at fb.com<mailto:huayang at fb.com>> wrote:
Hi, Matt,

Thanks for your review. Just wondering if I should submit another diff to
revise the issues given by contrib/check-node.py?



On 10/17/12 4:10 PM, "Matt Mackall" <mpm at selenic.com<mailto:mpm at selenic.com>> wrote:

>On Wed, 2012-10-17 at 14:01 -0700, Huayang Guo wrote:
>> # HG changeset patch
>> # User Huayang <huayang at fb.com<mailto:huayang at fb.com>>
>> # Date 1349479654 25200
>> # Node ID be43ef5cd839673f76dd0b65a9f053a6e3ac76af
>> # Parent  fa714f3ed2989aff64c267c9935251d9fc4f31ee
>> convert: normalize paths in filemaps (issue3612)
>Queued for default with some fixes. contrib/check-code.py has asked me
>to tell you:
> >     ''' We use posixpath.normpath to support cross-platform path
> trailing whitespace
> >     if path == None:
> comparison with singleton, use 'is' or 'is not' instead
>Mathematics is the supreme nostalgia of our time.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121018/5903a523/attachment.html>

More information about the Mercurial-devel mailing list