[PATCH 9 of 9] scmutil: add bad character checking to checknewlabel

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Oct 18 16:39:54 CDT 2012


On 18 oct. 2012, at 23:36, Kevin Bullock wrote:

> On Oct 18, 2012, at 4:26 PM, Matt Mackall wrote:
> 
>> On Thu, 2012-10-18 at 16:19 -0500, Kevin Bullock wrote:
>>> On Oct 18, 2012, at 4:01 PM, Matt Mackall wrote:
>>> 
>>>> On Wed, 2012-10-17 at 22:31 -0500, Kevin Bullock wrote:
>>>>> # HG changeset patch
>>>>> # User Kevin Bullock <kbullock at ringworld.org>
>>>>> # Date 1350528126 18000
>>>>> # Node ID 0f80eecd05b8271461e9da83f5dcc9dee6ef6089
>>>>> # Parent  5b18705d6e80c044c3a46a7a3bf728d58b2b276a
>>>>> scmutil: add bad character checking to checknewlabel
>>>> 
>>>> These are queued for default, thanks. Check-code says hi.
>>> 
>>> Bwuh? I made sure to run test-check-code.t before submitting. What'd it find?
>> 
>> a) check-code found a _("%s" % x)
>> b) pyflakes found an unused var (all chars)
> 
> I keep using that test-check-code.t. I do not think it does, what I think it does.
> 
> *facepalm*

I've been there before… But I also always run the full test-suite before patchbombing anything. It took about 2 minutes on Firefly (-j 15) maybe you should ask for an account up there.

-- 
Pierre-Yves


More information about the Mercurial-devel mailing list