[PATCH 9 of 9] scmutil: add bad character checking to checknewlabel

Matt Mackall mpm at selenic.com
Fri Oct 19 13:41:51 CDT 2012


On Fri, 2012-10-19 at 13:11 -0300, Wagner Bruna wrote:
> > +            raise util.Abort(_("%r cannot be used in a %s name" %
> > +                               (c, kind)))

> The 'kind' became untranslated here.

The infamous _("%s" % x). Check-code missed this because of the line
break.

>  Actually, this message can't be translate
> correctly at all, since 'tag', 'bookmark' and 'branch' could have eg.
> different grammatical genders in the target language.
> 
> Perhaps the parameter could hold a whole message defined by the caller instead?

Eventually there will be multiple types of error messages in here.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list