[PATCH 9 of 9] scmutil: add bad character checking to checknewlabel

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Oct 19 15:27:25 CDT 2012


On Oct 19, 2012, at 1:41 PM, Matt Mackall wrote:

> On Fri, 2012-10-19 at 13:11 -0300, Wagner Bruna wrote:
>>> +            raise util.Abort(_("%r cannot be used in a %s name" %
>>> +                               (c, kind)))
> 
>> The 'kind' became untranslated here.
> 
> The infamous _("%s" % x). Check-code missed this because of the line
> break.

Hrm, it's correct in the code as you queued it. Maybe check-code did actually catch it?

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list