[PATCH] Fix incorrect error code for `hg remove --after dirname`

Sergey sergemp at mail.ru
Sun Oct 21 17:48:33 CDT 2012

On Sun, 21 Oct 2012 16:50:40 Matt Mackall wrote:

> 'hg help rm' going back as far as 1.6 (Jun 2010) says:
>     Returns 0 on success, 1 if any warnings encountered.
> And this is clearly a warning:
>                  ui.warn(_('not removing %s: file is untracked\n') % m.rel(f))
> So the current behavior is correct as documented. Changing it to fix
> hgsvn risks breaking other tools and scripts that _reasonably depend on
> long-standing documented behavior_. This is not the sort of risk we like
> to take.

I guess, non-existing files cannot be untracked. So the warning in
that case was also a bug. But it was fixed in 14604:b1a534335548.
There's no warning any more, only non-zero exit code. I thought it
was just a typo (4 spaces missing).


More information about the Mercurial-devel mailing list