[PATCH 0 of 5] isolate configuration of subrepos

Matt Mackall mpm at selenic.com
Mon Oct 22 10:51:57 CDT 2012


On Mon, 2012-10-22 at 12:19 +0200, Simon Heimberg wrote:
> We agreed how to handle this.
> I have just resent the patch series about isolating the configuration of
> repositories.
> The patches about isolating extensions between repositories remain the
> responsibility of FUJIWARA Katsunori. He will maybe resend them soon.
> 
> Greetings,
> Simon
> 
> On 2012-10-19, 00:44 -0500 Matt Mackall wrote:
> > On Fri, 2012-10-05 at 05:02 +0200, Simon Heimberg wrote:
> > > Subrepos get the configuration of the parent repo in several places. 
> > > This happens because the "normal" ui is passed to the subrepo. This ui 
> > > (which is passed around by the commands) is the same as repo.ui and 
> > > contains repo specific configuration.
> > > 
> > > When the patch [1 of 4 V2]* of FUJIWARA Katsunori and patches 4 and 5 of 
> > > this series are applied, this does not happen anymore. No hooks from 
> > > containing repos will run anymore. issue2904 will be fixed.
> > 
> > These patches have been sitting in my mailbox for weeks because every
> > time I try to figure out what's going on with them, I get too confused
> > and context switch. Why do I have 10 apparently conflicting patches in
> > three groups in my inbox when the bug is fixed by three patches? Why do
> > I have two people telling me to apply the other person's patches
> > instead, but still sending me patches? Are there bugs other than 2904
> > that are getting fixed here?
> > 
> > It'd be much easier for me if you two decided together which patches
> > should go in and send me one series.
> > 
> > Also, this doesn't have a subsystem:
> Several files are modified. What subsystem should I choose? The topic is
> isolation of the configuration for subrepos. 

http://mercurial.selenic.com/wiki/ContributingChanges

 * start with the most useful topic keyword (eg command name, subsystem)

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list