[PATCH 9 of 9] scmutil: add bad character checking to checknewlabel
Thomas Arendsen Hein
thomas at intevation.de
Wed Oct 24 05:50:31 CDT 2012
* Kevin Bullock <kbullock+mercurial at ringworld.org> [20121018 23:37]:
> On Oct 18, 2012, at 4:26 PM, Matt Mackall wrote:
> > On Thu, 2012-10-18 at 16:19 -0500, Kevin Bullock wrote:
> >> On Oct 18, 2012, at 4:01 PM, Matt Mackall wrote:
> >>> These are queued for default, thanks. Check-code says hi.
> >>
> >> Bwuh? I made sure to run test-check-code.t before submitting. What'd it find?
> >
> > a) check-code found a _("%s" % x)
> > b) pyflakes found an unused var (all chars)
>
> I keep using that test-check-code.t. I do not think it does, what I think it does.
It tests "contrib/check-code.py". If you want to use check-code.py
to check hg, use test-check-code-hg.t ... and you want
test-check-pyflakes.t, too.
Yes, it seems easier to run the full suite :)
Regards,
Thomas
--
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
More information about the Mercurial-devel
mailing list