[PATCH] Fix incorrect error code for `hg remove --after dirname`

Matt Mackall mpm at selenic.com
Wed Oct 24 13:39:40 CDT 2012


On Tue, 2012-10-23 at 03:42 +0300, Sergey wrote:
> On Mon, 22 Oct 2012 15:44:16 Matt Mackall wrote:
> 
> > Yes, but it's from this codepath. Your patch breaks this correct,
> > documented behavior:
> > 
> >  $ hg rm --after nosuch ; echo $?
> >  nosuch: No such file or directory
> >  0
> 
> You're right. I had not checked that case. Sorry...
> 
> > Here's the patch/test I came up with:
> > [...]
> > -  $ cd ..
> > +handling of untracked directories and missing files
> > [...]
> 
> Just curious, have you intentionally dropped "cd .."?

Yes, though that was bad form on my part as it was an unrelated change.
There seems to be some disagreement about whether these no-ops should
exist at the end of tests.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list