[PATCH 9 of 9] scmutil: add bad character checking to checknewlabel

[Kevin Bullock]

On Oct 24, 2012, at 5:50 AM, Thomas Arendsen Hein wrote:

> * Kevin Bullock <kbullock+mercurial at ringworld.org> [20121018 23:37]:
>> On Oct 18, 2012, at 4:26 PM, Matt Mackall wrote:
>>> On Thu, 2012-10-18 at 16:19 -0500, Kevin Bullock wrote:
>>>> On Oct 18, 2012, at 4:01 PM, Matt Mackall wrote:
>>>>> These are queued for default, thanks. Check-code says hi.
>>>> 
>>>> Bwuh? I made sure to run test-check-code.t before submitting. What'd it find?
>>> 
>>> a) check-code found a _("%s" % x)
>>> b) pyflakes found an unused var (all chars)
>> 
>> I keep using that test-check-code.t. I do not think it does, what I think it does.
> 
> It tests "contrib/check-code.py". If you want to use check-code.py
> to check hg, use test-check-code-hg.t ... and you want
> test-check-pyflakes.t, too.
> 
> Yes, it seems easier to run the full suite :)

Sure, once I've run the more specific tests to make sure I haven't broken the obvious things. But running the full test suite takes longer than I am willing to wait before patchbombing. Isn't this partly what we have the buildbot for?

I'm not saying I never run the full suite locally. But it takes >15m, so it usually happens *after* I've sent a patch (if at all, and I'm trying to be better about this).

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock