[PATCH 4 of 5 STABLE] bookmark: remove useless line in `validdest`

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Oct 24 17:32:21 CDT 2012


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at logilab.fr>
# Date 1351095077 -7200
# Branch stable
# Node ID bbf650099da1cb369cf76c3f5fdea0fef9da9ef3
# Parent  3b474ae49202d098bc4717eba9f90ca660cfd1af
bookmark: remove useless line in `validdest`

This case is already covered by the `if old == new:` conditional at the start of
the function.

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -267,7 +267,6 @@
             mutable = [c.node() for c in validdests if c.mutable()]
             succs.update(obsolete.allsuccessors(repo.obsstore, mutable))
             validdests = set(repo.set('%ln::', succs))
-        validdests.remove(old)
         return new in validdests
     else:
         return old.descendant(new)


More information about the Mercurial-devel mailing list