[PATCH STABLE] clone: show status "updating to bookmark @"

Adrian Buehlmann adrian at cadifra.com
Fri Oct 26 16:03:34 CDT 2012


On 2012-10-26 22:49, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1351274290 -7200
> # Branch stable
> # Node ID fdbfbcaf9edf51cbc48bbf79145023a86e7c9514
> # Parent  52c7e171e35563c8f27bd74bc12b2de45fe99fa6
> clone: show status "updating to bookmark @"
> 
> When updating to the @ bookmark, the branch name it is on is rather subordinate
> and we are updating to that bookmark, not to a branch.
> 

On 2012-10-26 20:18, Thomas Arendsen Hein wrote:
> * Adrian Buehlmann <adrian at cadifra.com> [20121026 19:32]:
>> On 2012-10-26 15:10, Thomas Arendsen Hein wrote:
>>> The message that gets printed looks like:
>>>    $ hg clone . cloned-bookmarks
>>>    updating to branch default
>>>    2 files updated, 0 files merged, 0 files removed, 0 files unresolved
>>>    active bookmark: @
>>
>> When I read your code changes, I asked myself why shouldn't this be
>>
>>     $ hg clone . cloned-bookmarks
>>     updating to bookmark @
>>     2 files updated, 0 files merged, 0 files removed, 0 files unresolved
>>
>> because you are updating to a bookmark in that case, not to a branch.
>>
>> The branch seems of rather subordinated importance to me in that case.
> 
> There still might be a named branch, e.g. right now you will get the
> stable branch when checking out main or crew, but in after the
> release it will be the default branch again.
> 
> Additionally to not break software grepping for this for some
> reason.

http://mercurial.selenic.com/wiki/CompatibilityRules#Commands

<excerpt>
 - Output formats for commands with output likely to be parsed (especially log
   and status) are intended to be stable enough to be parsable by dumb scripts
   and tools
- Other commands may occasionally add or change output
</excerpt>

I think this change in this output is in-line here and acceptable.

In fact, it is more correct with this change than without, as we have a
behavior change anyway.



More information about the Mercurial-devel mailing list