[PATCH 2 of 2 STABLE V2] clone: show status "updating to bookmark @"

Thomas Arendsen Hein thomas at intevation.de
Tue Oct 30 07:23:47 CDT 2012


* Kevin Bullock <kbullock+mercurial at ringworld.org> [20121029 04:15]:
> On 28 Oct 2012, at 1:50 PM, Adrian Buehlmann wrote:
> 
> > # HG changeset patch
> > # User Adrian Buehlmann <adrian at cadifra.com>
> > # Date 1351431528 -3600
> > # Branch stable
> > # Node ID 48311398b9db83f1317d2b968018817383b8c2dd
> > # Parent  a4bd2433b517d370a5f52547d1583ad65cd7593c
> > clone: show status "updating to bookmark @"
> > 
> > if bookmark @ is not on the default branch, we show
> > 
> >  updating to bookmark @ (on branch <name>)
> 
> I'm +1 on this, but can we drop the parentheses?

I would have liked to avoid the branchname lookup code in two
places, but passing the status message down and sometimes inserting
the branch name and sometimes not would make the code probably too
ugly.

So +1 on this, too.

Parentheses or not would both fine for me. What do the others want?

Regards,
Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list