Please read: only you can prevent test suite bloat

Bryan O'Sullivan bos at
Wed Oct 31 12:21:06 CDT 2012

On Tue, Oct 30, 2012 at 4:18 PM, Matt Mackall <mpm at> wrote:

> And yet I'm seeing new patches submitted on a nearly daily basis from
> subscribers to this list
> that ignore this, some of them being accepted by crew members who
> haven't read it either.

Since this is clearly aimed at me:

I read that wiki page, and I don't push changes that add new tests. (Also,
I am bummed at the implied claim that an oversight on one small point means
that I must either have not read the document or have chosen to ignore it.)

The commit that you got riled up over does follow the "fold your test into
an appropriate existing test" dictum from that wiki page. You're right that
it doesn't adapt a pre-existing hunk of a test so that it tests several
things at once. This is simply because that is a subtle point that is quite
easy to overlook during a review, not because I haven't read that policy or
disagree with its intent.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Mercurial-devel mailing list