[PATCH stable] bundle: add the revset expression to show bundle contents(issue3487)

Tomasz Kłeczek tomasz.kleczek at gmail.com
Wed Oct 31 18:56:01 CDT 2012


On Wed, Oct 31, 2012 at 4:15 PM, Patrick Mézard <patrick at mezard.eu> wrote:

> We are currently in code freeze, could you resend once it is finished?
>

Sure.


> > +    try:
> > +        bundlenodes = repo.changelog.bundlenodes
> > +    except AttributeError:
> > +        raise util.Abort(_("no bundle provided - specify with -R"))
> > +    revs = map(lambda n: repo[n].rev(), bundlenodes)
>
> Don't you want to turn that into a set to avoid costly array lookups?


Thanks, I am going to change it to:
revs = set(repo[n].rev() for n in bundlenodes)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121031/08af7565/attachment.html>


More information about the Mercurial-devel mailing list