[PATCH STABLE] obsolete: import base85 without using a from clause, fixing --pure

Greg Ward greg at gerg.ca
Sat Sep 1 16:24:56 CDT 2012

On 24 August 2012, Matt Mackall said:
> Seems to me nothing in the mercurial directory should ever need or want
> to do "from mercurial import...". Including util, here. Not only is it
> going to confuse pure mode, it's going to make demand-loading messier.

Clarity. Pity the poor newbie who has no idea where 'store' or
'scmutil' comes from. "from mercurial import scmutil" immediately
answers that question.

Understanding Mercurial from the source code can be a tall order. We
should be trying to make it *easier* IMHO.


More information about the Mercurial-devel mailing list