[PATCH] tests: adjust hook creation for ksh89

Jim Hague jim.hague at acm.org
Mon Sep 3 11:02:48 CDT 2012


On Monday 03 Sep 2012 14:21:40 Mads Kiilerich wrote:
> On 09/03/2012 02:01 PM, Jim Hague wrote:
> > -  > pretxncommit.foo = sh -c "echo \"pretxncommit \$HG_NODE\"; hg id -r
> > \$HG_NODE" +  > pretxncommit.foo = sh -c 'echo "pretxncommit \$HG_NODE";
> > hg id -r \$HG_NODE'
> > 
> >     > EOF
> 
> This will probably fail on windows. The command line will be executed by
> cmd.exe, and ' is not handled correctly in that environment.

Ah. Good point.

> I think it would be better to use
>    ...
>    pretxncommit.foo = sh -c "echo \\"pretxncommit \\$HG_NODE\\"; hg id
> -r \\$HG_NODE"
>    ...
> 
> Does that work for  you?

It doesn't, but 

pretxncommit.foo = sh -c "echo \\"pretxncommit \$HG_NODE\\"; hg id -r 
\$HG_NODE"

does. I will resent the patch.
-- 
Jim Hague - jim.hague at acm.org          Never trust a computer you can't lift.


More information about the Mercurial-devel mailing list