[PATCH] record: checks for valid username before starting recording process (issue3456)

Sumeet sumeet at fb.com
Wed Sep 5 12:13:21 CDT 2012


# HG changeset patch
# User Sumeet <sumeet at fb.com>
# Date 1346096470 25200
# Node ID 795d68f450e6ea79c8069b422b3ec260ffc0e7ae
# Parent  c6f88e7f95b764e23b7e0b4353c5a6458bbc3cc4
record: checks for valid username before starting recording process (issue3456)

diff --git a/hgext/record.py b/hgext/record.py
--- a/hgext/record.py
+++ b/hgext/record.py
@@ -496,6 +496,9 @@
         raise util.Abort(_('running non-interactively, use %s instead') %
                          cmdsuggest)
 
+    # make sure username is set before going interactive
+    ui.username()
+
     def recordfunc(ui, repo, message, match, opts):
         """This is generic record driver.
 
diff --git a/tests/test-record.t b/tests/test-record.t
--- a/tests/test-record.t
+++ b/tests/test-record.t
@@ -246,10 +246,19 @@
   +9
   +10
   
+Modify end of plain file with username unset
+
+  $ echo 11 >> plain
+  $ unset HGUSER
+  $ hg record --config ui.username= -d '8 0' -m end plain
+  abort: no username supplied (see "hg help config")
+  [255]
+
 
 Modify end of plain file
 
-  $ echo 11 >> plain
+  $ HGUSER="test"
+  $ export HGUSER
   $ hg record -d '8 0' -m end plain <<EOF
   > y
   > y


More information about the Mercurial-devel mailing list