[PATCH 1 of 2] test-hybridencode: remove x00 character case

Adrian Buehlmann adrian at cadifra.com
Wed Sep 5 12:29:51 CDT 2012


On 2012-09-05 19:06, Bryan O'Sullivan wrote:
> On Wed, Sep 5, 2012 at 5:17 AM, Adrian Buehlmann <adrian at cadifra.com
> <mailto:adrian at cadifra.com>> wrote:
> 
>     test-hybridencode: remove x00 character case
> 
> 
> Pushed to crew, thanks.

Thanks.

>     precludes implementation in C
> 
> 
> More accurately, \x00 is not a valid path name component on any platform.

store.encodefilename() has been encoding \x00 to "~00" for quite a while
now (even predates fncache repo layout).

I guess the inverse store.decodefilename() will happily decode "~00" to
\0x00 as well.

Both should perhaps raise an error instead. In particular, trying to
decode "~00" should raise an error.




More information about the Mercurial-devel mailing list