[PATCH 1 of 3 v4] store: implement fncache path mangling code in C

Bryan O'Sullivan bos at serpentine.com
Fri Sep 7 14:25:20 CDT 2012

On Fri, Sep 7, 2012 at 12:07 PM, Adrian Buehlmann <adrian at cadifra.com>wrote:

> Bryan, can I ask you what "slop" means?

In this context, it means "leftovers". It serves the same purpose as this
code in store.py:

If I would have had to write such kind of code, I would be almost 100%
> sure *I* would have (unintentionally) inserted at least 5 bugs in it.

Me too, since I fixed about that many while writing it, mainly due to all
the extra test cases you added to test-hybridencode.py.

I'm not certain there are no remaining bugs, but the current code is quite
a lot closer to correct.

I'll be writing a fuzz tester to exercise this code further.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120907/ca075989/attachment.html>

More information about the Mercurial-devel mailing list